cyclops icon indicating copy to clipboard operation
cyclops copied to clipboard

Support OCI helm registry auth

Open petar-cvit opened this issue 1 year ago • 8 comments

Is your feature request related to a problem? Please describe. When fetching private templates, Cyclops injects auth data (username and password) into the request. This is supported only when fetching templates from GitHub, but not when fetching from an OCI registry.

Here is the example of how credentials are fetched from the cluster when fetching a template from GitHub and here is the function fetching data from an OCI based registry.

petar-cvit avatar Aug 23 '24 14:08 petar-cvit

Hi @petar-cvit please review https://github.com/cyclops-ui/cyclops/pull/525 as the commit for this also ended up in the same PR. Please reject (https://github.com/cyclops-ui/cyclops/pull/525/commits/8c062f57c154dd8e8a12129edc1ac1db621bf6fc) and I will send a separate PR

pravintargaryen avatar Aug 24 '24 05:08 pravintargaryen

Hey @pravintargaryen, can you close the existing PRs and create new ones with changes only for a single issue?

petar-cvit avatar Aug 24 '24 18:08 petar-cvit

@petar-cvit please check

pravintargaryen avatar Aug 25 '24 14:08 pravintargaryen

New Quest! image New Quest!

A new Quest has been launched in @cyclops-ui’s repo. Merge a PR that solves this issue to loot the Quest and earn your reward.


Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #524 to link your PR to this Quest.

Questions? Check out the docs.

quest-bot[bot] avatar Oct 04 '24 06:10 quest-bot[bot]

@quest-bot embark

pravintargaryen avatar Oct 04 '24 06:10 pravintargaryen

@pravintargaryen has embarked on their Quest. 🗡

  • @pravintargaryen has been on GitHub since 2022.
  • They have merged 17 public PRs in that time.
  • Their swords are blessed with JavaScript and HTML magic ✨
  • They have contributed to this repo before.

Questions? Check out the docs.

quest-bot[bot] avatar Oct 04 '24 06:10 quest-bot[bot]

Is this issue still open for hacktoberfest 2025, I will like to work on it

tanbirali avatar Sep 29 '25 14:09 tanbirali

@tanbirali it probably will be

pravintargaryen avatar Sep 29 '25 15:09 pravintargaryen