webots icon indicating copy to clipboard operation
webots copied to clipboard

added section to correct corners that are separated by commas instead…

Open RugnirViking opened this issue 3 years ago • 2 comments
trafficstars

… of newlines

Description Encountered an issue in which when upgrading some SimpleBuildings were converted correctly but others appeared flipped. upon investigation it was found that those SimpleBuildings were using comma separated vectors for its corners instead of newline separated like the script expects. This PR goes through and changes any comma-separated lists of corners into newline separated before the file is parsed by the main script

Additional context Persuant to a conversation had in the webots discord on 19th september 2022

RugnirViking avatar Sep 19 '22 14:09 RugnirViking

I have made it so that the vectors are padded correctly, I had a go at putting everything into the single loop but it wasn't working quite right and I need to get back to work @stefaniapedrazzi

RugnirViking avatar Sep 20 '22 08:09 RugnirViking

@RugnirViking: I just sent you an invite to become a member of the Webots-committers group so that you should be to merge your PR directly and create new PRs on the cyberbotics repos.

omichel avatar Sep 21 '22 06:09 omichel