Carl Pearson
Carl Pearson
I'll try to move it over to algorithms.
Almost certainly 2341. Maybe intel 19 doesn't like deprecating a type alias.
@ndellingwood I think 2393 did the trick, okay to close?
@lucbv how would you like to proceed here?
Corresponding Core PR: https://github.com/kokkos/kokkos/pull/6844
@vlkale I changed the name of the callback to mark_kernel_static_info and defined a 512-byte struct, so while this currently only tracks functor size, it could be extended to include other...
Things we're apparently allowed to do after `resumeFill()`: * `removeLocalIndices()`: core/test/CrsGraph/CrsGraph_UnitTests0.cpp:247 * `setAllToScalar()`: core/example/advanced/Benchmarks/CrsMatrixDenseRowUnpack.cpp:621 * `sumIntoLocalValues()`: core/example/advanced/Benchmarks/CrsMatrix_sumIntoLocalValues.cpp:160 * `replaceGlobalValues()`: core/example/Lesson03-Power-Method/lesson03_power_method.cpp:359 * modify entries in the `values` view: core/src/Tpetra_applyDirichletBoundaryCondition.hpp:232 * `reindexColumns()`:...
Files that may need clarifying updates to documentation and/or comments - [ ] core/example/Lesson03-Power-Method/index.doc - [ ] core/example/Lesson03-Power-Method/lesson03_power_method.cpp - [ ] core/example/Lesson04-Sparse-Matrix-Fill/index.doc - [ ] core/ext/TpetraExt_MatrixMatrix_decl.hpp - [ ] core/guide/src/Examples/SourceCode/power_method_1.cpp...
@kyrillh can you comment on how what you're doing is different than this example in the unit tests of `insertLocalValues` after `resumeFill`? https://github.com/trilinos/Trilinos/blob/7b858e5b668f4ac6fb0874884e8e4ced3f5fd51c/packages/tpetra/core/test/CrsMatrix/CrsMatrix_MultipleFillCompletes.cpp#L125-L132
Okay, great. We can still improve the documentation to help out with this in the future