Christian Weiske

Results 301 comments of Christian Weiske
trafficstars

You're providing a single commit that modifies 236 files. This is not a sensible way to get a review. Split the changes into single commits that do/fix one thing instead...

This should be obsolete with v2.0.0 that adds support for TYPO3 v13: https://github.com/andersundsehr/aus_driver_amazon_s3/releases/tag/2.0.0

Another production example: ``` $ composer-lock-diff --no-links --md | Production Changes | From | To | |--------------------|---------|--------| | fluidtypo3/flux | 10.0.10 | 10.1.0 | | Indirect Production Changes | From...

I've rebased against latest master. I'm using this since a year and it is working fine.

This patch is incomplete and shows warnings, e.g. > PHP Warning: Undefined array key 3 in composer-lock-diff on line 125 I've made a separate patch in #46 that builds upon...

It disappeared from the chrome web store now: #131 and #146 .

My issue with the regex was that the "[verbose regex](https://docs.python.org/3/library/re.html#re.VERBOSE)" option is enabled, which means that spaces are ignored. I had to replace the spaces with `\s+` in my regex.

(This problem is described in the documentation: https://phpspreadsheet.readthedocs.io/en/stable/topics/Looping%20the%20Loop/#using-rangetoarray) > But many worksheets do have trailing empty rows (or columns); and it is quite common for an Excel spreadsheet to have...

It seems as if the base feature (`ignoreEmptyAttributes`) is available in fluid core, but no attribute in `v:tag` exposes this option. Please reopen.