cwegener
cwegener
> I will need to test out your PR and report the results. Quick feedback from my initial testing of this patch: Testing with - `openai` package from PyPI (which...
> > My main issue that I'm looking into at the moment is the boot-strapping of the PEP 517 build environments for `pip wheel` > > @cwegener could you please...
I had another look. And I think I figured out where the issue with this approach is. `pip download` will perform unwanted build steps in order to generate metadata. Those...
Thanks Jordan. There also is another one over here. I've been using that patch on Ubuntu 22.04 LTS for 6+ months now. https://github.com/jordansissel/pleaserun/pull/156
> In the case of PyPA, it seems the first release was in 2020, and that’s pretty recent to require such a thing given some fpm users likely have Python...
> So, I think the number of packages that will be impacted by such change will actually be quite small. Specifically, the likely packages that will be impacted would fall...
> though I think we should keep the pkg_resources code for older versions of Python where importlib is not available (if this is relevant). Not needed. There is a "shim"...
> the Python docs report that importlib requires Python 3, and I’m not sure how many folks (Python 2 isn’t quite dead?) will be negatively impacted by such a change....
I think the failing integration tests look unrelated to your work? And they were probably fixed here -> https://github.com/betodealmeida/shillelagh/pull/364/commits/48bb76a7f9409b8ba05e71019dcb65c57efa5c4c You should just run `pylint`, `black` and `mypy` tests locally though...
For pre-commit, just make sure it's installed on your local machine https://pre-commit.com/#install And then run `pre-commit install` once off in your local shillelagh repo, and then all those local hooks...