composer-patches icon indicating copy to clipboard operation
composer-patches copied to clipboard

Published 20 hours ago • verified publisher icon cweagans

Backport the removal of PATCHES.txt to 1.x branch

Open donquixote opened this issue 6 years ago • 4 comments
trafficstars

In issue #140 / PR #213, the patch report generation (PATCHES.txt) was removed for the 2.x branch. A release in this new branch has not happened yet.

I am going to provide a PR that backports this change to the 1.x branch.

donquixote avatar Mar 15 '19 22:03 donquixote

The two commits from #213 will be squashed in the backported PR.

donquixote avatar Mar 15 '19 22:03 donquixote

I applied the change with a PR patch from #259 -- works great, I see no side effects! (Tested on a Drupal 8 project, with a patch to Drupal core.)

(Side note: I lol'ed when a "PATCHES.txt" file was created in vendor/cweagans/composer-patches 😁 -- not a bug at all, obviously, just a funny moment!)

alisonjo315 avatar Dec 19 '19 15:12 alisonjo315

I'm okay with this, but can it be behind a config flag? I know of at least one user that relies on this and I don't want to break their workflow. Definitely okay with this being an opt-out thing though.

cweagans avatar Dec 19 '19 16:12 cweagans

Hey! Would you mind? I made a PR for this.

awd-studio avatar Nov 15 '20 13:11 awd-studio

There is now a config flag for this in 1.x. main doesn't have this functionality at all.

cweagans avatar Feb 07 '23 20:02 cweagans