Cameron Eagans

Results 304 comments of Cameron Eagans
trafficstars

Try running it again with '-vvv'. You may see more info. One common thing to look into if you know that these patches apply elsewhere is whether or not you...

So in that case, the patch doesn't apply cleanly. You'll have to fix the patch. That's a little outside the scope of what I can directly support here though.

Hm, composer-preserve-paths should take care of this, but evidently, it's not. I'll take a look.

Was this ever working (in any version of this plugin)? It's possible that it had never worked.

Just clicking through some of the Composer files on Github -- I didn't see anywhere that PRE_PACKAGE_UNINSTALL would have been dispatched. It's entirely possible that simply dispatching that event before...

(And for the record, I was aware of composer-preserve-paths -- I just figured that calling `$installationManager->uninstall()` would have triggered the event. I don't actually use composer-preserve-paths, though, and therefore didn't...

Is there something that we can do in this plugin (other than manually dispatching the event) that would cause that line to be run? I haven't stepped through this too...

I'm not sure. I don't really want to just blindly merge it because even though it solves the problems with composer-preserve-paths, it might have unintended effects on other plugins that...

Thank you for opening this -- I'm swamped but will review ASAP. Thank you @gapple for the original PR as well. One (hopefully) quick thing: let's just pick a hashing...

Makes sense to me. I probably won’t have time to work on this in the near future but I’ll happily review a PR against either branch if someone wants to...