cvxpy icon indicating copy to clipboard operation
cvxpy copied to clipboard

Cleanup ``performance_test`` and ``test_benchmarks``

Open Transurgeon opened this issue 1 year ago • 2 comments

Description

Please include a short summary of the change. This PR deletes some unused tests that have coverage elsewhere in the codebase. Benchmarks have all been ported over to the benchmarks repo and are currently mostly being skipped. Issue link (if applicable):

Type of change

  • [ ] New feature (backwards compatible)
  • [ ] New feature (breaking API changes)
  • [ ] Bug fix
  • [x] Other (Documentation, CI, ...)

Contribution checklist

  • [x] Add our license to new files.
  • [x] Check that your code adheres to our coding style.
  • [x] Write unittests.
  • [x] Run the unittests and check that they’re passing.
  • [x] Run the benchmarks to make sure your change doesn’t introduce a regression.

Transurgeon avatar Oct 18 '24 01:10 Transurgeon

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


William Zijie Zhang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 18 '24 01:10 CLAassistant

NVM all the CI are failing, looks like a COPT issue?

Transurgeon avatar Oct 18 '24 01:10 Transurgeon