Hierarchical-Localization icon indicating copy to clipboard operation
Hierarchical-Localization copied to clipboard

add data in matches for doppelganger

Open awarebayes opened this issue 2 years ago • 2 comments

This proposal will allow for seamless integration with the Doppelgangers repository.

awarebayes avatar Sep 20 '23 10:09 awarebayes

  • I need more context - why are these new fields created? There is no such fields in the output of any our models.
  • I would only accept to depend on the official Doppelganger repository, not on a fork of it.
  • Since the inference of LoFTR is slow (much more than LightGlue), I don't think that it is acceptable to require running LoFTR for each image pair. Doppelganger should work on top of sparse matches, which requires retraining the model.

sarlinpe avatar Sep 20 '23 11:09 sarlinpe

See https://github.com/cvg/Hierarchical-Localization/issues/308

I need more context - why are these new fields created? There is no such fields in the output of any our models.

I use them here

I would only accept to depend on the official Doppelganger repository, not on a fork of it.

Already made a PR: link

Since the inference of LoFTR is slow (much more than LightGlue), I don't think that it is acceptable to require running LoFTR for each image pair. Doppelganger should work on top of sparse matches, which requires retraining the model.

Working on it, chef

awarebayes avatar Sep 20 '23 12:09 awarebayes