cvat icon indicating copy to clipboard operation
cvat copied to clipboard

Fix issue with LDAP not working due to function mismatch

Open Kira-Kitsune opened this issue 5 months ago • 1 comments
trafficstars

Motivation and context

Resolves #9382 I have ran into the same issue, I have done some searching and saw that the LDAP create_user was changed in #9272 for the LDAP implementation to have two new arguments created and raw which is not needed in the Django LDAP Authentication, I think the change was just meant to fall in line with the django post_save signal

How has this been tested?

I removed the lines and rebuilt and tried logging in with LDAP and it succeed.

Checklist

  • [x] I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] ~~I have updated the documentation accordingly~~
  • [ ] ~~I have added tests to cover my changes~~
  • [x] I have linked related issues (see GitHub docs)

License

  • [x] I submit my code changes under the same MIT License that covers the project. Feel free to contact the maintainers if that's a concern.

Kira-Kitsune avatar May 28 '25 09:05 Kira-Kitsune

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.79%. Comparing base (dcccc44) to head (24726b2).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9478   +/-   ##
========================================
  Coverage    73.78%   73.79%           
========================================
  Files          448      448           
  Lines        46774    46772    -2     
  Branches      3943     3943           
========================================
+ Hits         34514    34515    +1     
+ Misses       12260    12257    -3     
Components Coverage Δ
cvat-ui 77.73% <ø> (+<0.01%) :arrow_up:
cvat-server 70.73% <0.00%> (+<0.01%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Jun 16 '25 21:06 codecov-commenter

@Kira-Kitsune Thank you for the contribution!

Could you add a note to the changelog? https://github.com/cvat-ai/cvat/blob/develop/CHANGELOG.md?plain=1#L9-L14

azhavoro avatar Jun 17 '25 10:06 azhavoro