cvat
cvat copied to clipboard
Updated page with allocation report
Motivation and context
How has this been tested?
Checklist
- [x] I submit my changes into the
developbranch - [x] I have created a changelog fragment
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see GitHub docs)
- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas, cvat-core, cvat-data and cvat-ui)
License
- [x] I submit my code changes under the same MIT License that covers the project. Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
-
New Features
- Introduced modular validation layouts for jobs and tasks, enhancing data management.
- Added new interfaces for serialized job and task validation layouts, improving type specificity.
-
Bug Fixes
- Resolved inconsistencies by replacing outdated validation layout types across the application.
-
Documentation
- Updated documentation to reflect changes in validation layout handling and new interface structures.
Walkthrough
The changes involve a significant restructuring of the validation layout system for jobs and tasks within the application. The ValidationLayout class has been replaced by two new classes: JobValidationLayout and TaskValidationLayout. This update includes modifications to import statements, the removal of the old ValidationLayout type, and the introduction of new serialized types. Additionally, the session implementation and various UI components have been updated to reflect these changes, enhancing type safety and clarity in handling job-related data.
Changes
| File(s) | Change Summary |
|---|---|
cvat-core/src/api.ts, cvat-core/src/index.ts, cvat-core/src/session.ts, cvat-ui/src/cvat-core-wrapper.ts, cvat-ui/src/reducers/index.ts |
Updated import statements to replace ValidationLayout with JobValidationLayout and TaskValidationLayout. |
cvat-core/src/api.ts |
Removed ValidationLayout class; added JobValidationLayout and TaskValidationLayout classes. |
cvat-core/src/index.ts |
Removed ValidationLayout type; added JobValidationLayout and TaskValidationLayout types. |
cvat-core/src/server-proxy.ts |
Updated method signature for validationLayout to return a union type of new serialized types. |
cvat-core/src/server-response-types.ts |
Renamed SerializedValidationLayout to SerializedJobValidationLayout; added SerializedTaskValidationLayout interface with new properties. |
cvat-core/src/validation-layout.ts, cvat-core/src/session-implementation.ts |
Updated constructors and method signatures in JobValidationLayout and TaskValidationLayout to return appropriate types instead of ValidationLayout. |
cvat-ui/src/components/quality-control/task-quality/allocation-table.tsx, cvat-ui/src/components/quality-control/task-quality/summary.tsx |
Updated Props interfaces to include new properties related to validation layouts and modified existing properties for consistency. |
cvat-ui/src/reducers/index.ts |
Added SET_VALIDATION_LAYOUT action type and corresponding action creator for managing state related to task validation layouts. |
Poem
In the garden where changes bloom,
New layouts rise, dispelling gloom.
Jobs and tasks, so neat and bright,
Validation's path now feels just right.
Hops of joy, we celebrate,
Structure strong, we elevate! 🐰✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Codecov Report
Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.
Project coverage is 74.27%. Comparing base (
c557f70) to head (b598ff0). Report is 6 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #8558 +/- ##
========================================
Coverage 74.26% 74.27%
========================================
Files 400 400
Lines 43218 43238 +20
Branches 3909 3914 +5
========================================
+ Hits 32096 32113 +17
- Misses 11122 11125 +3
| Components | Coverage Δ | |
|---|---|---|
| cvat-ui | 78.73% <75.86%> (+<0.01%) |
:arrow_up: |
| cvat-server | 70.46% <66.66%> (-0.01%) |
:arrow_down: |
Quality Gate passed
Issues
6 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code