cvat icon indicating copy to clipboard operation
cvat copied to clipboard

Remove `quality` tab from analytics

Open klakhov opened this issue 1 year ago • 4 comments

Motivation and context

How has this been tested?

Checklist

  • [ ] I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary (cvat-canvas, cvat-core, cvat-data and cvat-ui)

License

  • [ ] I submit my code changes under the same MIT License that covers the project. Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features

    • Enhanced the Analytics Page to improve access to Project and Task entities.
    • Simplified rendering logic for the Task Quality Component.
  • Bug Fixes

    • Streamlined the test cases for ground truth jobs, improving overall test efficiency.
  • Refactor

    • Removed Redux-based state management from the Analytics Page, indicating a shift towards local state handling.
    • Updated styling components, reducing complexity in task quality reporting styles.

klakhov avatar Aug 20 '24 10:08 klakhov

[!IMPORTANT]

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent updates to the CVAT UI involve a significant refactor of the AnalyticsPage component, moving away from Redux for state management and simplifying the rendering logic. Style changes in styles.scss streamline UI elements related to task quality, while the Cypress test suite for ground truth jobs has been restructured for efficiency, omitting unnecessary checks. Overall, these changes aim for a more focused and efficient user experience and testing framework.

Changes

File(s) Change Summary
cvat-ui/src/components/analytics-page/... Refactored AnalyticsPage to remove Redux dependencies, simplifying job update handling and task quality rendering.
cvat-ui/src/components/analytics-page/... Removed multiple CSS classes related to task quality, streamlining styles for the analytics overview.
tests/cypress/e2e/features/ground_truth_jobs.js Refined ground truth job tests by removing redundant functions, leading to a more concise test structure.

Poem

🐰 In the meadow where we play,
Changes bloom like flowers in May.
Redux hops away, a lighter load,
Styles now simpler, a clearer road.
Test cases dance, streamlined and bright,
Analytics shines, a joyful sight! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 20 '24 10:08 coderabbitai[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.93%. Comparing base (afbb143) to head (042709e). Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8323      +/-   ##
===========================================
- Coverage    83.34%   82.93%   -0.42%     
===========================================
  Files          393      391       -2     
  Lines        41579    41549      -30     
  Branches      3843     3830      -13     
===========================================
- Hits         34655    34459     -196     
- Misses        6924     7090     +166     
Components Coverage Δ
cvat-ui 78.70% <ø> (-0.89%) :arrow_down:
cvat-server 86.68% <ø> (ø)

codecov-commenter avatar Aug 20 '24 11:08 codecov-commenter

We probably need to merge it together with #8329

bsekachev avatar Aug 22 '24 11:08 bsekachev

Let's close this one as these conflicts were solved in #8329. I will continue working there.

bsekachev avatar Sep 03 '24 10:09 bsekachev