cvat
cvat copied to clipboard
Fix quality computation for tasks with skeletons and normal labels
Motivation and context
- Fixed quality report computation in tasks with non-skeleton labels after skeleton labels
How has this been tested?
Unit tests
Checklist
- [ ] I submit my changes into the
developbranch - [ ] I have created a changelog fragment
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see GitHub docs)
- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas, cvat-core, cvat-data and cvat-ui)
License
- [ ] I submit my code changes under the same MIT License that covers the project. Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
-
Bug Fixes
- Improved quality computation for tasks with both skeletons and normal labels in the Computer Vision Annotation Tool (CVAT).
-
Tests
- Added a new test to ensure quality can be computed correctly when a non-skeleton label follows a skeleton label.
[!IMPORTANT]
Review skipped
Auto incremental reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
Walkthrough
This update enhances the quality computation in the Computer Vision Annotation Tool (CVAT) by addressing how tasks with skeleton and normal labels are managed. A new parameter, label_id_mapper, was introduced to refine the confusion matrix creation and shape matching processes. Additionally, a test was added to verify the quality computation when labels transition from skeleton to non-skeleton.
Changes
| File | Change Summary |
|---|---|
cvat/apps/quality_control/quality_reports.py |
Introduced label_id_mapper parameter in _make_zero_confusion_matrix and modified its usage in _find_closest_unmatched_shape. |
tests/python/rest_api/test_quality_control.py |
Added test_can_compute_quality_if_non_skeleton_label_follows_skeleton_label to verify quality computation scenarios. |
Poem
In the fields where labels dance, A mapper joined for clearer chance. Shapes aligned with mindful grace, A test to see if quality’s place. Skeletons and labels, side by side, Now in harmony, they glide. 🌟🛠️
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
@coderabbitai review
Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.64%. Comparing base (
6d49b89) to head (ab1a977). Report is 5 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #8100 +/- ##
========================================
Coverage 83.63% 83.64%
========================================
Files 383 383
Lines 40503 40507 +4
Branches 3831 3830 -1
========================================
+ Hits 33876 33881 +5
+ Misses 6627 6626 -1
| Components | Coverage Δ | |
|---|---|---|
| cvat-ui | 79.68% <ø> (-0.01%) |
:arrow_down: |
| cvat-server | 87.26% <100.00%> (+<0.01%) |
:arrow_up: |
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code