cursorless icon indicating copy to clipboard operation
cursorless copied to clipboard

Bug with `"small paint"` when cursor is after pair

Open pokey opened this issue 3 years ago • 2 comments

In the following text:

(hello)

If the cursor is at the end of the line, saying "take small paint" selects hello, which is inconsistent with behaviour when the cursor is at the beginning of the line, where it instead selects (hello), as expected.

pokey avatar Aug 03 '22 16:08 pokey

The problem is that we find a matching pair at the end which is incorrect which regards to requireStrongContainment: true I think the problem is in this file. It doesn't even have a reference to requireStrongContainment https://github.com/pokey/cursorless-vscode/blob/5d049ee704bc8491f3b716e5824a0a2bb8d13114/src/processTargets/modifiers/surroundingPair/findDelimiterPairContainingSelection.ts

AndreasArvidsson avatar Sep 12 '22 09:09 AndreasArvidsson

Yeah fwiw I think #901 is probably caused by the same issue with strong containment

pokey avatar Sep 12 '22 15:09 pokey