cursorless icon indicating copy to clipboard operation
cursorless copied to clipboard

Published 20 hours ago • verified publisher icon cursorless-dev

eslint: Use consistent-type-imports

Open auscompgeek opened this issue 3 years ago • 3 comments

esbuild will parse and ignore type imports, so let's actually give it this information.

@typescript-eslint/consistent-type-imports

Ref: #714

Checklist

auscompgeek avatar Jul 17 '22 07:07 auscompgeek

Seems fine, but a couple questions:

  • [ ] Will VSCode automatically start using this style when it does an auto-import for us, both via
    • [ ] autocomplete, and
    • [ ] quick fix?
  • [ ] Also, will pre-commit automatically fix this for us? I can't remember if we have eslint --fix set up

pokey avatar Jul 17 '22 08:07 pokey

This is ESLint autofixable, so will show up as a quick fix in VSCode. I'd love to know how to make autoimport do the right thing though.

We currently don't have pre-commit running ESLint, I recall you had concerns around pulling in the relevant plugin versions?

auscompgeek avatar Jul 17 '22 09:07 auscompgeek

This is ESLint autofixable, so will show up as a quick fix in VSCode.

Ah no I don't mean once it's already imported. I mean if you have a symbol that you haven't yet imported and you run quick fix to do the auto import

I'd love to know how to make autoimport do the right thing though.

Does it not? It might be smart enough to use type if we have this eslint config

We currently don't have pre-commit running ESLint, I recall you had concerns around pulling in the relevant plugin versions?

Ah right yeah I remember now. I think the issue was we had nothing to auto fix so didn't seem worth it. Maybe we should revisit now we have more auto fixers?

pokey avatar Jul 17 '22 09:07 pokey

@auscompgeek I'm curious why you closed this one. I'm overall supportive of this direction, modulo the questions above

pokey avatar Oct 01 '22 16:10 pokey

I'm not really sure the questions are addressable in any straightforward manner. There's also (unsurprisingly) a lot of merge conflicts by this point, so needs a rebase.

Happy for someone else to tackle this, but this probably doesn't win too much for us right now.

auscompgeek avatar Oct 02 '22 03:10 auscompgeek

I think basically it would involve just pulling this branch, then trying to do an auto-import and see what happens. But I agree this rule probably isn't a massive win for us, so probably not super high priority

pokey avatar Oct 02 '22 16:10 pokey