cursorless icon indicating copy to clipboard operation
cursorless copied to clipboard

init-launch-sandbox: Stop capturing stdout/stderr

Open auscompgeek opened this issue 3 years ago • 2 comments

This stops capturing and buffering stdout and stderr when installing extensions in the sandbox, so live progress is visible.

Checklist

auscompgeek avatar Jul 04 '22 10:07 auscompgeek

Yes there was problem with the output on windows. I can try this on when I get back home

AndreasArvidsson avatar Jul 04 '22 10:07 AndreasArvidsson

Hmm. I ran this on macOS, haven't tried on other platforms. If it's a problem I guess we can keep piping and reprint the stream?

auscompgeek avatar Jul 04 '22 10:07 auscompgeek

@AndreasArvidsson when you get a minute it would be awesome if you could try this out on Windows; I believe that's what's blocking this PR

pokey avatar Sep 12 '22 12:09 pokey

stdout appears to be working on windows

AndreasArvidsson avatar Sep 12 '22 12:09 AndreasArvidsson

@AndreasArvidsson do you remember what the problem was originally? Unfortunately we didn't leave any comment. Here's the commit where you fixed Windows originally fwiw

pokey avatar Sep 12 '22 12:09 pokey

I think it was that stdout wasn't showing. I can't remember exactly. Now it appears to be working at least.

AndreasArvidsson avatar Sep 12 '22 12:09 AndreasArvidsson