cursorless
cursorless copied to clipboard
Force tab size on test run
- This fixes test failures related to different local configurations
- Tests expect tabSize to be 4
Fixes: https://github.com/cursorless-dev/cursorless/issues/598
Checklist
- N/A - I have added tests
This will only force tab size to be for when re-running the tests. I think we need to add the same to the test recorder otherwise every test will be recorded with the user tab setting, but run with a fixed setting.
This will only force tab size to be for when re-running the tests. I think we need to add the same to the test recorder otherwise every test will be recorded with the user tab setting, but run with a fixed setting.
I'll second what @AndreasArvidsson says here. I think if we detect that the extension is running in debug mode, we should make the same tabSize change
Not important, but I'm still a little curious about why this didn't break for me, with other tests that I've recorded.
@pokey — I'll likely add the setting here as well rather than in the actual extension.
https://github.com/cursorless-dev/cursorless/blob/main/src/test/suite/recorded.test.ts#L74-L78
Not important, but I'm still a little curious about why this didn't break for me, with other tests that I've recorded.
did you record tests that include snippet wrapping? I think those are the ones that will break
@pokey — I'll likely add the setting here as well rather than in the actual extension.
https://github.com/cursorless-dev/cursorless/blob/main/src/test/suite/recorded.test.ts#L74-L78
Sorry not sure I follow—that won't impact recording right?
did you record tests that include snippet wrapping? I think those are the ones that will break
Nope, you're right. One other indent and fold test broke as well though
Sorry not sure I follow—that won't impact recording right?
Multi-tasking between emails, sorry. You're right.
@pokey I think you can have a look at this one now