cursorless icon indicating copy to clipboard operation
cursorless copied to clipboard

Update the range updater code with better support for insertion and selection

Open AndreasArvidsson opened this issue 3 years ago • 2 comments

Goal is to remove EditWithRangeUpdater

  • [ ] Support multiple edits in the same position and keeping track off their individual resulting range
  • [x] Support updating the editor's selection internally
  • [x] Think of a better api to to use different updating behavior(OpenOpen etc)

Bugs that this change can be used to fix:

  • [x] https://github.com/cursorless-dev/cursorless/issues/1030
  • [ ] #202
  • [x] #742

AndreasArvidsson avatar Jun 02 '22 16:06 AndreasArvidsson

Related to #202 and #672

pokey avatar Jun 03 '22 12:06 pokey

Also have a look at registerReplaceEditList, because that has a mechanism to associate changes that come back from VSCode with edits provided in performDocumentEdits. It is not perfect; eg if two edits come in at the same place with the same text, it can mix them up. We might need to make it more robust for this new purpose

pokey avatar Jun 03 '22 13:06 pokey