cursorless
cursorless copied to clipboard
cursorless-dev
Add unit sub-selection for values in SCSS/CSS
:wave: Hey @Will-Sommers, how's this PR going? I'd personally love to see this land; let us know if someone else will need to pick this up.
Heyo @auscompgeek feel free to take it over!
This weekend I should be able to push up my code related to the regex version of this. I need to scroll back in my convos with @pokey to see where we fell on take every unit within a string.
Looks good to me. If there are any details we can discuss them in the meeting.
Looks good to me. If there are any details we can discuss them in the meeting.
well there's the ever-present parser vs regex discussion 😅 https://github.com/cursorless-dev/cursorless/pull/722#discussion_r893104146. In this case I think parser wins due to the multiple unit from key thing, but curious what you think
Looks good to me. If there are any details we can discuss them in the meeting.
well there's the ever-present parser vs regex discussion 😅 #722 (comment). In this case I think parser wins due to the multiple unit from key thing, but curious what you think
I think that the syntax tree is a better match here. Personally I don't really have the need to support units in any other language anyhow. Not one that I can think of on top of my head.
Personally I don't really have the need to support units in any other language anyhow. Not one that I can think of on top of my head.
Talon script within sleep()?
Personally I don't really have the need to support units in any other language anyhow. Not one that I can think of on top of my head.
Talon script within
sleep()?
The amount of times I want to change just the unit in a Talon script sleep is more or less zero. Turning 500ms into 1s sure but in that case I would not target just the unit.
Also the sleep format is not part of Talonscript or the Tree sitter for it. It's just a string that gets parsed python side. Of course this could be worked around, but I personally don't think it's worth it.