Bring range sets wrong source mark

[AndreasArvidsson]

a
b

|

bring past air chuck source removes the new text as well as the source

[AndreasArvidsson]

@pokey I have investigated this issue and the problem is related to DecorationRangeBehavior.OpenOpen

Since the insert is performed at the end of the source range and we have OpenOpen the source range expands to cover the destination range.

[pokey]

Ah right. Is there any reason we want that to be open, or is the fix as easy as just making it closed?

[AndreasArvidsson]

I can't think of one. Am just wondering why we chose that in the first place?

[pokey]

🤷 I'd be tempted to just change it and see if any tests break

[AndreasArvidsson]

44 tests with changed that marks. hmm

[pokey]

Maybe we're trying to use it to capture the "that" mark with "bring after"? Are the "that" marks ending up empty?

We should maybe do closed with "source" mark and open with "that" mark?

[pokey]

Although I wonder if we're getting the correct "that" mark either here

[AndreasArvidsson]

The that mark is correct. It's only source that expands to the destination

[AndreasArvidsson]

The simplest example of this problem is bring air after air take source