cursorless icon indicating copy to clipboard operation
cursorless copied to clipboard

Published 20 hours ago • verified publisher icon cursorless-dev

Fix slow DFA compilation

Open pokey opened this issue 1 year ago • 2 comments

Cursorless DFA compilation has slowed down in the past year. Here are the two major culprits:

  • https://github.com/cursorless-dev/cursorless/pull/2050
  • https://github.com/cursorless-dev/cursorless/pull/1637

We should figure out how to mitigate these slowdowns

To try for https://github.com/cursorless-dev/cursorless/pull/1637:

  • [x] Comment out https://github.com/cursorless-dev/cursorless/pull/1637/files#diff-9cbdeabb002e18cf9f64d3ca24e45b18e4d7433d5dc29abbf4f96df1f72609ecR81
  • [x] Comment out https://github.com/cursorless-dev/cursorless/pull/1637/files#diff-ad70c9f7733ed465149fcdfe7b4b2a300c71938633e4896dc05f90d92c992fe3R2 (and in other talon file)
  • [ ] Comment out https://github.com/cursorless-dev/cursorless/pull/1637/files#diff-ad70c9f7733ed465149fcdfe7b4b2a300c71938633e4896dc05f90d92c992fe3R1 (and in other talon file)

pokey avatar Jan 19 '24 12:01 pokey

Update: removing this single line cuts DFA by half! https://github.com/cursorless-dev/cursorless/blob/aa95401c1504954aec6c84dc2f878b45b0a845b5/cursorless-talon/src/cursorless.talon#L2

pokey avatar Jan 25 '24 18:01 pokey

@pokey can we close this one?

AndreasArvidsson avatar Feb 10 '24 05:02 AndreasArvidsson

Compilation time looks fine for me

AndreasArvidsson avatar Jan 24 '25 14:01 AndreasArvidsson