nginx_phantom_token_module icon indicating copy to clipboard operation
nginx_phantom_token_module copied to clipboard

Fix or remove intermittent failing test that uses ngx_debug_log

Open gary-archer opened this issue 3 years ago • 0 comments

This code at the start of the handler is working fine, but the debug line does not always come out in test logs when I run it, causing TEST 5 in config.t to fail intermittently. For now I have raised this minor issue in case it occurs for others.

if (!module_location_config->enable)
{
    ngx_log_debug0(NGX_LOG_DEBUG_HTTP, request->connection->log, 0, "Module disabled");
    return NGX_DECLINED;
}

Tests are configured with a debug level like this, so it should work, and the log output is written if the C code uses a higher log level (though the logging would then be wrong).

error_log /Users/userid/dev/nginx_phantom_token_module/t/servroot/logs/error.log debug;

We could disable the test like this if we cannot find a way to make it work deterministically. Perhaps debug output is flushed in a delayed manner:

--- SKIP

Currently this is not happening. It could be related to this section of the wiki.

gary-archer avatar Jul 13 '22 17:07 gary-archer