Kiran Rao

Results 40 comments of Kiran Rao

In my opinion the snippets that I posted above are not suitable to go into the library as-is. They were just some ideas on what problems could be encountered when...

@Gregory991 Your problem is that `vehicleDao.flowOnUserVehicle(id)` returns a `Flow` and you are wrapping that in a `Result`. What you want to do instead is _map_ instead of _wrap_ (at least...

@michaelbull I wonder if there is scope for something like this to address @Gregory991's usecase ```kt fun Result.toFlow(flowProducer: (V) -> Flow): Flow flowProducer(this.value).map { Ok(it) } is Err -> flowOf(this)...

While you're at it, you might also make the configurable properties as custom attributes.

I use slightly modified versions of the proposed functions: ```kt inline fun Result.assertOk(assertion: (value: V) -> Unit) { try { assertion.invoke(this.expect { "Expected the result to be an Ok, found...

^ This seems to be the most logical approach. It lends itself to easy testing, and it keeps everything consistent. My only concern with this approach is that it could...

@Glurt This is how we have implemented it right now: ViewModel adds a listener for the external change, and in response to the change it emits a `Change` object. The...

Will this work? ```kotlin val scope = if (includeNonProjectItems) GlobalSearchScope.allScope(project) else GlobalSearchScope.projectScope(project) ```

I had the same problems with tags and I commented them. Then I run into the same problem "not something we can merge". Seems to be a git problem rather...

I use a shimmer effect with landscapist-coil and I see this problem. The first time that this screen is opened, there's the regular shimmer (for a few seconds) because the...