Results 292 comments of Dannii Willis

Transpilation should def be a later step than modularising.

Hmm, this must be because of some conflict with the Inform 7 template styles. That 100% height is important so I'll have to see what I can do about it.

I'm on board with this. For the files in dist/ I'm currently just telling nginx to proxy them to the Github CDN. It would be great if I can detect...

Could we keep all the IFIDs and use them when querying IFDB? I haven't looked at the IFDB API recently to see if we could pass multiple IFIDs at once.

Oh, I wonder if the issue is having two IFIDs?

I thought I was already accounting for that warning... It should be possible to change how the file is named. While we wait for potential Babel improvements.

Multiple IFID lines is also an issue, as this line assumes there will only be 3 lines of Babel output (after ignoring a warning) https://github.com/curiousdannii/parchment/blob/ed192dd8a378ad784b7c6cf6bc34d76619af0917/src/iplayif.com/app/src/metadata.ts#L147

It's perfectly legitimate to return a promise instead, and sometimes that would result in cleaner code. This should be at most a warning, not a requirement.

I guess.. though I think it would be slightly lower performance (probably not noticeable unless it's a really hot function.) Hmm. If you did require async functions to be AsyncFunctions,...