reactjs-social-login icon indicating copy to clipboard operation
reactjs-social-login copied to clipboard

Add esm build using microbundle-crl

Open anver opened this issue 3 years ago • 2 comments

The previous fix will not actually work for cra and custom webpack setup, since react app mostly use esm imports as well this package is not meant for server side rendering, esm will be quiet helpful. I've made a change so that the microbundle-crl will generate esm build files. I've tried to generate both esm and cjs bundles but unfortunately it's not working on microbundle-crl. It should be a breeze when using esbuild.

This will actually fix the module not exported error for many users. I confirmed it several times before the PR

anver avatar Feb 16 '22 21:02 anver

Thank you for your contribution. I'll check it.

cuongdevjs avatar Feb 17 '22 01:02 cuongdevjs

Hi. Why do we need to change this? I've installed 2.0.1 our lib on my machine with CRA, I saw it work fine. I don't know why need this.

This is needed since the build is generating only cjs version which is mostly used on node servers since this library will be used 99% on client-side, most of the users need esm version which is what I have done and works on all setup.

anver avatar Feb 17 '22 12:02 anver