elm-css-modules-loader icon indicating copy to clipboard operation
elm-css-modules-loader copied to clipboard

Bump elm and elm-css-modules-plugin

Open dan-lennox opened this issue 3 years ago • 0 comments
trafficstars

Purpose

Primarily to update elm-css-modules-plugin to ensure the changes in this PR are available, which adds "support for ESM exports" are available.

Changes

See commits. Needed to Bump Elm from 0.19.0 to 0.19.1-4 (matches Murmur) to be able to fix an issue with managing npm dependencies with later versions of node.

Context

We're trying to upgrade Murmur from Webpack 4 to Webpack 5. Murmur is using elm-css-modules-loader to load css modules for Elm files. Getting an error loading css module files in the form of:

require("@cultureamp/admin-sidebar/lib/styles.scss").default["active"]

TypeError: Cannot read properties of undefined (reading 'active')

So I think that correlates to the scenario in this this PR

However don't really know what I'm doing when it comes to Elm dependency management. So I wasn't able to verify this change actually fixes my issue (though I imagine it might just be a sane dependency bump in the worst case).

Might be worth discussing?

dan-lennox avatar Jul 22 '22 07:07 dan-lennox