docs icon indicating copy to clipboard operation
docs copied to clipboard

change doc for junit5

Open toepi opened this issue 5 years ago • 7 comments
trafficstars

have found the the documention is a little outdate to use cucumber with junit5, it reference to junit-vintage-engine. with is only correct if cucumber-junit will be used. since cucumber 5 it is possible to use junit5 native with cucumber-junit-platform-engine.

Why no pr? I'm unsure how to describe it in a good manner. Have only found out that the current stand is confusing new users.

toepi avatar Jun 21 '20 12:06 toepi

Hi @toepi - Thanks you for creating this issue. Would you be open to collaborating on a PR? You can get started by changing the things you have found to be outdated and people can review / add suggestion?

mlvandijk avatar Oct 06 '20 11:10 mlvandijk

@mlvandijk I'm waiting for https://github.com/junit-team/junit5/pull/2416. Once implemented we'll be feature complete with Junit 4.

mpkorstanje avatar Oct 06 '20 12:10 mpkorstanje

Good to know, thnx @mpkorstanje

mlvandijk avatar Oct 18 '20 11:10 mlvandijk

Is there even a sketch somewhere of how to use native JUnit 5 with cucumber-junit-platform-engine while excluding junit and the vintage engine? We added cucumber-junit-platform-engine and excluded junit and the vintage engine, and now it runs but says there are no tests. Adding back the vintage engine, it finds our tests. A working example posted to some public repo somewhere would be extremely useful, in lieu of documentation.

jimshowalter avatar Feb 04 '21 20:02 jimshowalter

Here's a working example. I cloned it, added excludes of junit and vintage engine, and it still works: https://github.com/cronn/cucumber-junit5-example

jimshowalter avatar Feb 04 '21 21:02 jimshowalter

This should help:

https://github.com/cucumber/cucumber-jvm/tree/main/junit-platform-engine

mpkorstanje avatar Feb 05 '21 07:02 mpkorstanje

I'd read that, but nothing beats a checked-in, working example.

jimshowalter avatar Feb 05 '21 15:02 jimshowalter