cube
cube copied to clipboard
cube-js
Fiscal and custom granularity support
Cube supports pre-aggregating data by a time dimension with respect to a chosen granularity. Currently, the following granularities are supported: second, minute, hour, day, week, month, quarter, and year.
We would like to make granularities configurable, including the support for such granularities like "fiscal quarter" (not necessarily aligned with the start of a year).
It's currently planned for October 2024.
Related issues:
- #177
Hey @benjackwhite, I've just pushed the latest commit 5519a07, which updates the snapshots for the Toolbar story.
This should resolve the failing Storybook visual regression test. I’ve also verified it locally by running the test using the command:
pnpm test:visual:ci:verify frontend/src/toolbar/Toolbar.stories.tsx
Looks like we’re good to go now!
Hey @benjackwhite, thank you for your support with the review and approval.
Could you please trigger the CI to re-run the visual regression test? I’ve updated the snapshots for the Toolbar story and confirmed that the test passes locally.
As this is one of my initial PRs to PostHog, I’m excited to see it through to completion :) I’m here to help with any remaining steps if needed.
TIA
@benjackwhite Looks like the storybook visual regression test is still failing.
However, after updating the snapshots (here's the commit), I had ran the tests locally using:
pnpm test:visual:ci:verify frontend/src/toolbar/Toolbar.stories.tsx
Locally, all tests were passing without any problems, as shown in the screenshot:
Do you have any suggestions on what I might be missing or what else I can try?
Appreciate your help!
This PR was stuck on my brain today and I thought there might actually be a better option... The issue with this one is that as soon as the element moves, the fixed position is lost forever. I put something together that allows "snapping" the position to different areas which I think works a little nicer.
Sorry for jumping in 🙈 without this PR I wouldn't have thought of the other solution for sure!
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.
