cube
cube copied to clipboard
refactor(cubesql): Introduce Portal with Empty state
Refactoring: Portal requires Prepared Statement as input, but prepared statement can be empty. Before this PR we used workaround with Option, which is not blocker for implementing pg_catalog.pg_cursors.
Codecov Report
Merging #5317 (03b8f4c) into master (363b42d) will increase coverage by
8.55%. The diff coverage is62.22%.
@@ Coverage Diff @@
## master #5317 +/- ##
==========================================
+ Coverage 75.62% 84.18% +8.55%
==========================================
Files 275 135 -140
Lines 33015 21330 -11685
Branches 2945 0 -2945
==========================================
- Hits 24968 17956 -7012
+ Misses 7539 3374 -4165
+ Partials 508 0 -508
| Flag | Coverage Δ | |
|---|---|---|
| cube-backend | ? |
|
| cubesql | 84.18% <62.22%> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.