easy-peasy icon indicating copy to clipboard operation
easy-peasy copied to clipboard

Expose storeState in effectOn dependency handlers.

Open methyl opened this issue 5 years ago • 5 comments

Also expose getActions in helpers.

Fixes #596.

methyl avatar Nov 10 '20 09:11 methyl

Codecov Report

Merging #598 (ae2b20e) into master (5c4c0e8) will decrease coverage by 9.11%. The diff coverage is 100.00%.

:exclamation: Current head ae2b20e differs from pull request most recent head 11322a9. Consider uploading reports for the commit 11322a9 to get more accurate results

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
- Coverage   94.97%   85.85%   -9.12%     
==========================================
  Files          18       19       +1     
  Lines         696      693       -3     
  Branches      139      135       -4     
==========================================
- Hits          661      595      -66     
- Misses         30       78      +48     
- Partials        5       20      +15     
Impacted Files Coverage Δ
src/effects.js 84.72% <100.00%> (+0.21%) :arrow_up:
src/create-transform.js 0.00% <0.00%> (-100.00%) :arrow_down:
src/persistence.js 66.89% <0.00%> (-29.73%) :arrow_down:
src/hooks.js 83.63% <0.00%> (-9.10%) :arrow_down:
src/lib.js 91.02% <0.00%> (-6.81%) :arrow_down:
src/create-store.js 97.18% <0.00%> (-2.82%) :arrow_down:
src/actions.js 100.00% <0.00%> (ø)
src/helpers.js 100.00% <0.00%> (ø)
src/provider.js 100.00% <0.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Nov 10 '20 09:11 codecov[bot]

@ctrlplusb can you take a look?

methyl avatar Dec 09 '20 21:12 methyl

@ctrlplusb can you take a look?

can this be done?

surethink avatar Nov 16 '21 14:11 surethink

@ctrlplusb , Please take a look at this 👍🏻 closed my issue in favor of this pr.

rbrtbrnschn avatar Mar 06 '22 08:03 rbrtbrnschn

@ctrlplusb Can you review this PR, please?

rainerbruemmer avatar Jun 13 '22 09:06 rainerbruemmer

Nice. I'll deal with the conflict for ya this week. Let's get this lined up for merge. :)

ctrlplusb avatar Oct 25 '22 13:10 ctrlplusb

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
easy-peasy ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 4:29PM (UTC)

vercel[bot] avatar Nov 04 '22 15:11 vercel[bot]

@ctrlplusb @jmyrland resolved the conflicts here. fwiw the VS Code diff is much clearer:

image

no-stack-dub-sack avatar Nov 04 '22 16:11 no-stack-dub-sack

LGTM too, thanks for your work!

methyl avatar Nov 04 '22 18:11 methyl

Thanks for your contribution @methyl 👏 This will be included in the release this week!

jmyrland avatar Nov 13 '22 12:11 jmyrland