easy-peasy icon indicating copy to clipboard operation
easy-peasy copied to clipboard

feat. Pass debug trace options to dev tools

Open el-gringo opened this issue 5 years ago • 5 comments

el-gringo avatar May 25 '20 14:05 el-gringo

Hi @el-gringo 👋

Thanks for this. I think it's great to consider custom config for the underlying dev tools. 👍

I had a brief look at your implementation. Would you consider an adaptation to your API?

It would be great to have the devTools configuration value to be either a boolean or a configuration object.

i.e.

createStore(model, {
  devTools: true
});

// or

createStore(model, {
  devTools: {
    tracing: true,
    traceLimit: 25
  }
});

What do you think?

ctrlplusb avatar May 25 '20 15:05 ctrlplusb

Yes, this is a great idea !

el-gringo avatar May 26 '20 10:05 el-gringo

@el-gringo are you still open to doing this :)

ctrlplusb avatar Sep 25 '20 14:09 ctrlplusb

I've made the changes. There is something that can be confusing about the name option which can be in the createStore option and in the devTools object. createStore(model, { name: 'test1', devTools: { name: 'test2' } }) test2 will be the store name

el-gringo avatar Sep 29 '20 16:09 el-gringo

Any chance of this getting revisited? Being able to trace would help eliminate a lot of my future "What's going on with this thing?" questions. :3

corysimmons avatar Feb 17 '22 18:02 corysimmons

I was unable to update this branch with the latest changes from master. I created #771 as a continuation of this work. Thanks for your efforts @el-gringo 👏

jmyrland avatar Sep 16 '22 13:09 jmyrland