annotate_models icon indicating copy to clipboard operation
annotate_models copied to clipboard
verified publisher icon ctran

Add AnnotateRoutes::AnnotationProcessor and AnnotateRoutes::RemovalProcessor

Open nard-tech opened this issue 5 years ago • 3 comments

cf. #790, #792

In order to refactor AnnoateRoutes, I added AnnotateRoutes::AnnotationProcessor and AnnotateRoutes::RemovalProcessor.

Refactoring AnnotateRoutes is finished in this PR and I would like to refactor AnnotateModels in a like way.

nard-tech avatar Apr 06 '20 01:04 nard-tech

Hello @nard-tech,

Is this still valid? If so, can you fix the conflict?

ctran avatar Mar 24 '21 04:03 ctran

Hello @ctran, the conflict is in .rubocop_todo.yml. So I excuted rubocop --auto-gen-config and re-generate .rubocop_todo.yml.

Now this PR is valid. Please merge if there is no problem.

nard-tech avatar Mar 29 '21 13:03 nard-tech

@ctran I cherry-picked the commit in #865 (e874241) to this pull request, and the CI worked fine.

So after #865 merged, I will rebase this pull request onto develop branch.

Please review again after rebase.

nard-tech avatar Apr 07 '21 07:04 nard-tech