Variable dictionary format - support Starent

Open pendula95 opened this issue 4 years ago • 4 comments

I already see that there was a request to support starent #30 . Unfortunately this vendor changed the spec and introduced 2 byte size of VSA Type and Length fields. Screenshot_2021-10-27_10-48-51

Previous request was not complete and I tried to make a fully scalable solution where we can support different sizes.

This is defined in dictionary and same practices is used by freeradius also.

Oct 27 '21 13:10 pendula95

I was careful to only edit logic regarding vendor specific attributes and this change should not affect default packets. Maybe now some public methods can be deleted but I did not want to remove any public methods in order not to break the API.

Oct 27 '21 17:10 pendula95

Could you rebase with "master" so the CI is triggered for this PR? Thanks.

Dec 15 '21 17:12 ctran

Branch is now rebased with master

Dec 24 '21 12:12 pendula95

Thanks. Does this change warrant a bump in major/minor version?

Jan 04 '22 02:01 ctran