TinyPNG icon indicating copy to clipboard operation
TinyPNG copied to clipboard

Add null handling to json serialization

Open manzanotti opened this issue 1 year ago • 2 comments

The move to System.Text.Json from Json.Net for v4 had the unfortunate side-effect of removing null handling, causing issue #21 to re-appear.

This PR adds it back in.

manzanotti avatar May 03 '24 09:05 manzanotti

Thanks for this.

This is probably something we should add unit tests for at some point.

ctolkien avatar May 07 '24 02:05 ctolkien

Gah, PAT has expired. I'll fix this up shortly.

ctolkien avatar May 07 '24 02:05 ctolkien

@manzanotti this is now available for testing on the GitHub Nuget repo here: https://github.com/ctolkien/TinyPNG/pkgs/nuget/TinyPNG

I'll get another prerelease for Nuget.org out soon.

ctolkien avatar May 16 '24 08:05 ctolkien

@manzanotti this is now available for testing on the GitHub Nuget repo here: https://github.com/ctolkien/TinyPNG/pkgs/nuget/TinyPNG

I'll get another prerelease for Nuget.org out soon.

Great, thanks. I might be able to test it this afternoon, otherwise it will be tomorrow, just working on something else at the moment.

manzanotti avatar May 16 '24 08:05 manzanotti

@manzanotti

Great, thanks. I might be able to test it this afternoon, otherwise it will be tomorrow, just working on something else at the moment.

No worries. Build has gone for NuGet prerelease: https://www.nuget.org/packages/TinyPNG/4.0.0-prerelease.68

Should show up soon ™️ once the NuGet indexing is done.

ctolkien avatar May 16 '24 08:05 ctolkien

@ctolkien Pre-release works fine, thanks.

manzanotti avatar May 22 '24 10:05 manzanotti