fluentcheck icon indicating copy to clipboard operation
fluentcheck copied to clipboard

Unit test all assertion methods

Open csparpa opened this issue 6 years ago • 7 comments

Ideally, test coverage of assertion methods (eg. is_none(), is_not_none(), etc.) should be 100%

csparpa avatar Feb 10 '19 15:02 csparpa

Hi @csparpa , I've submitted a pull request for the dicts testing. I will try to get some done on the other ones.

deanagan avatar Feb 16 '20 23:02 deanagan

Hello, is this issue still available?

I went over the files and found that for Check there is sequences tests missing

hedyhli avatar Jun 30 '20 00:06 hedyhli

The unit tests are not complete. From the last time I ran it, the code coverage isn't 100%.

deanagan avatar Jun 30 '20 00:06 deanagan

I ran it just now. We are at 94% code coverage.

deanagan avatar Jun 30 '20 00:06 deanagan

Yeah same for me, I started working on test_sequences for Check in my fork haven't finished yet. I'm not sure if the format is good either, you can check it out if you like. Although the python setup.py test is running ok, I haven’t checked the coverage report after adding test_sequences just yet

hedyhli avatar Jun 30 '20 05:06 hedyhli

@hedythedev thanks for contributing to fluentcheck! If you're testing the Check assertions, also pls take the chanche also to write the same tests - if missing - for the Is idiom.

csparpa avatar Jun 30 '20 08:06 csparpa

Got it, I checked a few hours ago that there were tests for sequences for Is, but tests for sequences for Check is missing so i was working on it as I said in the comment above :D

hedyhli avatar Jun 30 '20 08:06 hedyhli