Colin Snover
Colin Snover
Why is this not merged yet?
This PR was broken by whatever happened at https://github.com/kdave/btrfs-progs/pull/863#commits-pushed-bc39df6 that caused extra stuff to be added to the branch by someone else. Per your request I have `git rebase --skip`...
CI is failing because base branch is broken, not due to changes in this PR.
To get the easier administrative part out of the way: I didn’t actually sign off on whatever was changed, so you probably shouldn’t list me in such a field, but...
That trait sealing change is why the version is not updated. There’s no plan to update unless someone else does the work. Getting syn to do what we need it...
Hi, thanks for your report! There are a couple of things you could do now: 1. Encapsulate the `MessageData` inside a struct that has the `message_type` as a field so...
Hi, thanks for your report! Putting an annotation right before the closing `}` of the struct is not possible since that is not valid Rust struct syntax. Adding another directive...
Hi, thanks for your report! This is related to the general problem of writing offsets, #4. Other than actually fixing #4 so there is a simple blessed way to handle...
Hi, thanks for your report! Implementing `BinWrite` for `PosValue` seems reasonable to me since this is just a wrapper type for position metadata. I feel less certain about adding `From`...
Hi, thanks for your report! The longstanding general issue for handling offset writing is at #4 and then also a request for easier macro positioning at #161. This is also...