CoreWiki
CoreWiki copied to clipboard
csharpfritz
Search feature
Should we handle multi word search but the words can be in any order. For example in the homepage we could not only find this by entering "default home" but also "home default". This would allow for a less strict search.
As well as that do you think we should also enable search after every key-up trigger, like in search panel i in visual studio solution explorer instead on needing to select search button.
I think you're on to something, and we can update the SearchEngine by implementing the IArticlesSearchEngine interface with different providers and different search engine algorithms.
Let's look at this during a stream in the near future
Requirements:
- [ ] Should support fuzzy text search, not just a simple "like"
Breaking out autocomplete to a separate issue for tracking
I suggest we start with a basic Lucene.NET implementation. That should be fairly straightforward to implement, loosely based on the interface we already have (we can extend it of course). Once we have tagging/labeling in place we can then extend it to include aggregate searches like Amazon has on left hand side. We can already do some of that like grouping by author. That's all basic Lucene out of the box. So is autocomplete btw. I've done implementations like that before, but I would wait until #255 is merged as that would give a clean business object to index.
Hmm, why not make use of Azure Search for this? It brings Lucene and Fuzzy Search by default.
Oh yea... that's DEFINITELY an option for a search implementation.
If folks don't have an Azure account, or maybe they have access to another provider I want to ensure that they can use Corewiki.
I would want to create a separate project with the Azure Search specific implementation in it. This way, we can optionally configure it
Jeff
On Thu, Sep 20, 2018 at 12:20 PM Tiago Noronha [email protected] wrote:
Hmm, why not make use of Azure Search for this? It brings Lucene and Fuzzy Search by default.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/csharpfritz/CoreWiki/issues/237#issuecomment-423244845, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEy8UiTtadEyb3yj3Q_DlJSPxI1qVCBks5uc8BHgaJpZM4Vopzt .
Sure, we can have x different implementations all implementing the same interface. Then just pick your poison.
- DB Search directly on the database
- Lucene directory
- Azure Search
- ElasticSearch
Bingo!
I expect to start a "CoreWiki.Azure" project at Microsoft Ignite 2018, and put Azure-specific providers in that project.
Jeff
On Thu, Sep 20, 2018 at 1:01 PM bravecobra [email protected] wrote:
Sure, we can have x different implementations all implementing the same interface. Then just pick your poison.
- DB Search directly on the database
- Lucene directory
- Azure Search
- ElasticSearch
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/csharpfritz/CoreWiki/issues/237#issuecomment-423258523, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEy8ccwF4hdJrlsBptG5nc9pudfrXl2ks5uc8nwgaJpZM4Vopzt .
Gotcha.
So wait a bit until you create the project and then start accepting PR for it?
@tiagodenoronha Have you looked more into this, i've started on Azure search integration, but have hit a wall, take a look if you like
There’s a separate branch and project allocated for Azure integration.
Jeff
On Oct 13, 2018, at 10:05, ArgTang [email protected] wrote:
@tiagodenoronha Have you looked moer into this, ive started on Azure search integration, but have hit a wall, take a look if you like
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
@jeff I saw that, and have merged and moved the relevant files into the AzureProject in my branch :)
Glad to hear it, and can’t wait to take a further look at the PR
Jeff
On Oct 13, 2018, at 11:09, ArgTang [email protected] wrote:
@jeff I saw that, and have merged and moved the relevant files into the AzureProject in my branch :)
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.