pygdbmi
pygdbmi copied to clipboard
Read tokens correctly from GDB's output on Windows (#55)
- [x] I have added an entry to
CHANGELOG.md
Summary of changes
Original patch by Leonardo Pereira Santos (see PR https://github.com/cs01/pygdbmi/pull/55); updated by Marco Barisione.
This is the description for the original PR:
Removed the
make_non_blockingfunction. Refactored the_get_responses_windowsmethod to use separate threads and queues to make reading non-blocking. solution based on this StackOverflow answer
Tests don't pass on Unix and I'm reluctant to modify the code as I cannot test it on Windows so I will let this here in case anybody can help.
Fixes #54
Test plan
Tested by running
nox -s tests
CURRENTLY FAILING ON UNIX
If anyone else ends up taking this on, GitHub actions support windows, so adding a windows CI test would give good confidence in the change and ensure it doesn’t break in the future.