pygdbmi icon indicating copy to clipboard operation
pygdbmi copied to clipboard

Fixes issue # 54: `IoManager._get_responses_windows` mangles token when reading from stdout

Open leonardopsantos opened this issue 4 years ago • 4 comments

  • [x] I have added an entry to CHANGELOG.md

Summary of changes

Fixes issue #54

Removed the make_non_blocking function. Refactored the _get_responses_windows method to use separate threads and queues to make reading non-blocking. solution based on this StackOverflow answer

Test plan

Executed unit tests:

$ python test_pygdbmi.py
....
----------------------------------------------------------------------
Ran 4 tests in 8.774s

OK

leonardopsantos avatar May 19 '21 17:05 leonardopsantos

Hey, sorry for the ridiculously delayed reply, and thanks for taking the time to contribute.

Would you be interested in updating this to fix the merge conflict and make the CI tests pass? I will give you a quick review (within a few days) if you choose to.

cs01 avatar Jan 16 '22 06:01 cs01

I like that stack overflow answer. Getting rid of OS-specific stuff would be nice.

cs01 avatar Jan 16 '22 06:01 cs01

As the patch was not updated, I can take this and rebased it against master.

barisione avatar Aug 07 '22 17:08 barisione

Sorry for the super late reply. I'd appreciate it if anyone could rebase this as I switched jobs and no longer have access to a Windows system.

leonardopsantos avatar Aug 07 '22 18:08 leonardopsantos

I made a separate PR (https://github.com/cs01/pygdbmi/pull/76) to update this (as I cannot push to somebody else's repository). Tests don't pass on Unix and I'm reluctant to modify the code as I cannot test it on Windows.

barisione avatar Aug 13 '22 09:08 barisione