pygdbmi
pygdbmi copied to clipboard
Fixes issue # 54: `IoManager._get_responses_windows` mangles token when reading from stdout
- [x] I have added an entry to
CHANGELOG.md
Summary of changes
Fixes issue #54
Removed the make_non_blocking function. Refactored the _get_responses_windows method to use separate threads and queues to make reading non-blocking. solution based on this StackOverflow answer
Test plan
Executed unit tests:
$ python test_pygdbmi.py
....
----------------------------------------------------------------------
Ran 4 tests in 8.774s
OK
Hey, sorry for the ridiculously delayed reply, and thanks for taking the time to contribute.
Would you be interested in updating this to fix the merge conflict and make the CI tests pass? I will give you a quick review (within a few days) if you choose to.
I like that stack overflow answer. Getting rid of OS-specific stuff would be nice.
As the patch was not updated, I can take this and rebased it against master.
Sorry for the super late reply. I'd appreciate it if anyone could rebase this as I switched jobs and no longer have access to a Windows system.
I made a separate PR (https://github.com/cs01/pygdbmi/pull/76) to update this (as I cannot push to somebody else's repository). Tests don't pass on Unix and I'm reluctant to modify the code as I cannot test it on Windows.