android icon indicating copy to clipboard operation
android copied to clipboard

Replaced greenDAO with androidx.room

Open JaniruTEC opened this issue 2 years ago • 3 comments

Summary by CodeRabbit

  • New Features

    • Introduced Room library for enhanced database management.
    • Added new tests for database creation, access, and migrations.
    • Implemented automatic and manual database migrations for ~improved~ data integrity.
    • Added new data access objects (DAOs) for Cloud, Update Check, and Vault entities.
  • Enhancements

    • ~Improved database operation efficiency by utilizing Kotlin's type alias and constructor-based entity creation.~
    • ~Enhanced database schema with the addition of entities for Cloud, Update Check, and Vault.~
    • Streamlined database access in repository implementations with dependency injection.
  • Bug Fixes

    • Fixed issues related to database migrations and entity mapping for a more stable user experience.
  • Refactor

    • Transitioned from GreenDao to Room for database operations, resulting in cleaner and more maintainable code.
    • Refined database migration logic to use Room's built-in migration features.
  • Documentation

    • Updated internal comments to reflect changes in database handling and migration processes.
  • Chores

    • Updated build configurations to include necessary Room library dependencies.

JaniruTEC avatar Oct 18 '23 13:10 JaniruTEC

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 13 '23 10:11 CLAassistant

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The project transitions from using the GreenDAO plugin to Room for database management. It involves updating Room library versions, configuring annotation processors, and adding new test cases for database operations. Database access is refactored across various DAOs and repository implementations, with migrations adjusted for Room's SupportSQLiteDatabase. New entities and migration classes are introduced to handle database schema changes, and utility functions for thread handling are added.

Changes

File Path Change Summary
build.gradle, presentation/build.gradle Removed GreenDAO plugin; added Room dependencies.
buildsystem/dependencies.gradle, data/src/.../CryptomatorDatabase.kt, data/src/.../DatabaseAutoMigrationSpec.kt, data/src/.../DatabaseMigration.kt, data/src/.../DatabaseModule.kt Updated Room version; added new database classes for Room.
data/build.gradle Added kotlin-kapt plugin, configured Room schema tasks and annotation processor options.
data/src/androidTest/java/org/cryptomator/data/db/... Added new database tests and refactored existing ones to use Room's testing utilities.
data/src/main/java/org/cryptomator/data/db/... Refactored DAO interfaces and entities for Room; added type alias and migration classes.
data/src/main/java/org/cryptomator/data/db/mappers/... Updated entity mappers to use Room's DAOs and refactored construction of entities.
data/src/main/java/org/cryptomator/data/db/migrations/... Refactored migration classes from GreenDAO to Room's SupportSQLiteDatabase.
data/src/main/java/org/cryptomator/data/repository/... Refactored repository implementations to use DAO providers instead of direct database access.
util/src/main/java/org/cryptomator/util/... Added utility functions for thread checking and assertions.

🐇✨ In the realm of code, where the data trees grow,
Room took over GreenDAO's show.
Migrations dance, entities align,
As the database updates, all falls in line. 🌟📚


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

:heart: Share
:placard: Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jan 10 '24 15:01 coderabbitai[bot]

@coderabbitai review

JaniruTEC avatar Jan 10 '24 16:01 JaniruTEC

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 21 '25 09:10 github-actions[bot]