k-rail icon indicating copy to clipboard operation
k-rail copied to clipboard

Add Evict operator

Open alpe opened this issue 5 years ago • 6 comments

Resolves #18

Implementation of the evict operator - based on https://github.com/cruise-automation/k-rail/pull/47

Status: works on my machine.... 😆

Follow ups and improvements

  • [ ] Support metrics endpoint
  • [ ] Setup helm chart

Open questions

  • [ ] Which logger to use? klog vs (logrus)[github.com/sirupsen/logrus]
  • [ ] Should we do anything with "tainted" jobs or daemon-sets ?

alpe avatar Feb 03 '20 12:02 alpe

I am sorry that this PR is WIP for a while already. I am busy with other work and have not found the time to finish the tests and remaining todos, yet. I will do but feel free to close the PR for now to keep the list of PRs clean. ⌛️

alpe avatar Feb 24 '20 15:02 alpe

No worries, @alpe, take your time. All of your contributions are appreciated. I'll try to get the policy end of this sorted at some point, but I have been busy with a few things as well.

dustin-decker avatar Mar 04 '20 23:03 dustin-decker

Another usecase came up today for this: A maxAge annotation for Pods. Pods would get evicted after passing the duration specified.

This is handy for triggering re-provisioning of certificates, and also just enforce good hygiene and ensure that disruptions are tolerable.

dustin-decker avatar Jul 22 '20 18:07 dustin-decker

This PR was WIP for quite some time. I think it would be better if we can get the code into master and work on improvements together. There are some open questions and extensions that can be addresses by separate and smaller PRs later.

For testing the evictor, please see https://github.com/cruise-automation/k-rail/pull/54/commits/7bc0b3483e7dc3106ca0a4acd8645cecfc44cc5f for a configuration example. I have reverted the commit as it requires some testing.

alpe avatar Aug 06 '20 16:08 alpe

Sounds good to me. I'll take a look at doing that. Thanks for the update @alpe.

dustin-decker avatar Aug 06 '20 22:08 dustin-decker

👋 The k-rail project has been deprecated and is no longer under active development. We recommend taking a look at OPA Gatekeeper to see if it might meet your needs going forward.

Thanks for your contribution(s) to the project!

mark-adams avatar Jan 12 '23 16:01 mark-adams