MixrElixr icon indicating copy to clipboard operation
MixrElixr copied to clipboard

Alt + T shortcut to toggle theatermode

Open FierySama opened this issue 5 years ago • 4 comments
trafficstars

Alt + T key combo now toggles theater mode on and off! Escape still works too separately to exit theatermode

Description of the Change

Repurposed the escape event listener code to create a key combination of Alt + T that toggles theatermode on and off!

  • Updated tooltip image

  • Slowed down this toast by 1/4 of a second for slower readers, feel free to revert this image

Benefits

  • Ease of access shortcut keys, sometimes I want to exit the theater mode to look at vods/clips, but am too lazy to click the theatermode button again.

Possible Drawbacks

I admit I have no idea how this will function on MacOs. I used this https://www.w3.org/TR/uievents-code/#keyboard-key-codes . I assume alt/option + T on mac may still do the same thing?

Credit

SReject helped me remove redundant code before this commit, thanks Reject!

FierySama avatar Feb 04 '20 01:02 FierySama

This works fine on Chrome, however on Firefox while it works it brings up this menu each time. image

Will keep this PR open if anyone likes the concept enough

FierySama avatar Feb 04 '20 22:02 FierySama

It's terrible. since there is no check to see whether you're typing in chat, Shift + T means if you capitalize things in sentences often, you'll be toggling theater mode and off. This is the biggest flaw in this PR! ahhh!!!

FierySama avatar Feb 05 '20 01:02 FierySama

This is a great idea Fiery! I wonder if Shift + Alt + T or something to that effect would fit all browser types

ebiggz avatar Feb 05 '20 05:02 ebiggz

I wonder if Shift + Alt + T or something to that effect would fit all browser types

The AltLeft key used will work with iOS's options key aswell, if that is what you were musing

SReject avatar Feb 05 '20 06:02 SReject