oam-kubernetes-runtime icon indicating copy to clipboard operation
oam-kubernetes-runtime copied to clipboard

implement Trait patch back before workload emitted

Open ifree613 opened this issue 5 years ago • 8 comments

Ref to proposal https://github.com/crossplane/oam-kubernetes-runtime/blob/master/design/trait-separated-from-underlying-workload-should-patch-back.md

Signed-off-by: chengji.lsb [email protected]

ifree613 avatar Jul 23 '20 12:07 ifree613

Any progress on this PR? If @ifree613 doesn't have time, we can help continue to finish it. cc @wonderflow

hongchaodeng avatar Aug 06 '20 22:08 hongchaodeng

pending on this issue https://github.com/crossplane/oam-kubernetes-runtime/issues/157

wonderflow avatar Aug 07 '20 02:08 wonderflow

Just FYI, the strategicMergepatch is in a library at "k8s.io/apimachinery/pkg/util/strategicpatch"

ryanzhang-oss avatar Aug 27 '20 19:08 ryanzhang-oss

//oam-k8s-runtime will periodically check the status of patch trait. If the phase of status become Ready, the oam-k8s-runtime will gather the patch data from the ConfigMap. After all patch traits gathered, oam-k8s-runtime will patch all the information into workload

i have a little problem..where is this logic,periodically check and patch @wonderflow @ifree613

antiClocke avatar Dec 04 '20 02:12 antiClocke

when and who make the Trait from unReady to Ready?have some opinion? @wonderflow @ifee613

antiClocke avatar Dec 04 '20 02:12 antiClocke

//All patch traits MUST be created or updated before workload emit, and oam-k8s-runtime will be pending until all patch traits are ready. i am a fish,a questioin where is the pending logic, i d not fount

antiClocke avatar Dec 04 '20 05:12 antiClocke

@antiClocke Let's talk deep in wechat or Dingtalk, my ID is wonderflow

wonderflow avatar Dec 04 '20 05:12 wonderflow

@antiClocke Let's talk deep in wechat or Dingtalk, my ID is wonderflow

wechat

antiClocke avatar Dec 04 '20 05:12 antiClocke