provider-gcp
provider-gcp copied to clipboard
Add support for AutoscalingProfile to GKE
Description of your changes
Adds AutoscalingProfile field to the ClusterAutoscaling type
Fixes #462
I have:
- [X] Read and followed Crossplane's [contribution process].
- [X] Run
make reviewable testto ensure this PR is ready for review.
How has this code been tested
Fairly trivial change, but tested it manually in local setup.
@Feggah - any chance you can take a look here?
Hey @mastersingh24, sorry for the long time waiting for review. I will review it by the end of the weekend. Feel free to ping me again if needed
Hey @mastersingh24, sorry for the long time waiting for review. I will review it by the end of the weekend. Feel free to ping me again if needed
No worries! Thanks!
@Feggah - I think this should be good to go now (I hope)
@Feggah - any chance you can take a look?
@hasheddan - any chance you can find someone to review this?
@Feggah - if you could take another quick look, that would be great.
@Feggah - just my weekly friendly ping for a review! :-)
I probably need you to commit again, @mastersingh24. I can't run the GitHub action and their statuses are frozen -- so I can't merge it

Could you modify some tests and commit again without force-pushing? (I believe that this was the root cause of this bug)
@Feggah - thanks. added a new commit

@Feggah - are you able to approve the workflow now?
Yep, it worked. Thanks @mastersingh24!