provider-gcp icon indicating copy to clipboard operation
provider-gcp copied to clipboard

Add support for AutoscalingProfile to GKE

Open mastersingh24 opened this issue 3 years ago • 8 comments

Description of your changes

Adds AutoscalingProfile field to the ClusterAutoscaling type

Fixes #462

I have:

  • [X] Read and followed Crossplane's [contribution process].
  • [X] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Fairly trivial change, but tested it manually in local setup.

mastersingh24 avatar Oct 13 '22 12:10 mastersingh24

@Feggah - any chance you can take a look here?

mastersingh24 avatar Oct 15 '22 00:10 mastersingh24

Hey @mastersingh24, sorry for the long time waiting for review. I will review it by the end of the weekend. Feel free to ping me again if needed

Feggah avatar Oct 20 '22 22:10 Feggah

Hey @mastersingh24, sorry for the long time waiting for review. I will review it by the end of the weekend. Feel free to ping me again if needed

No worries! Thanks!

mastersingh24 avatar Oct 21 '22 07:10 mastersingh24

@Feggah - I think this should be good to go now (I hope)

mastersingh24 avatar Nov 01 '22 12:11 mastersingh24

@Feggah - any chance you can take a look?

mastersingh24 avatar Nov 11 '22 10:11 mastersingh24

@hasheddan - any chance you can find someone to review this?

mastersingh24 avatar Nov 15 '22 10:11 mastersingh24

@Feggah - if you could take another quick look, that would be great.

mastersingh24 avatar Nov 21 '22 09:11 mastersingh24

@Feggah - just my weekly friendly ping for a review! :-)

mastersingh24 avatar Dec 01 '22 15:12 mastersingh24

I probably need you to commit again, @mastersingh24. I can't run the GitHub action and their statuses are frozen -- so I can't merge it

image

Could you modify some tests and commit again without force-pushing? (I believe that this was the root cause of this bug)

Feggah avatar Dec 12 '22 20:12 Feggah

@Feggah - thanks. added a new commit

mastersingh24 avatar Dec 12 '22 21:12 mastersingh24

image

@Feggah - are you able to approve the workflow now?

mastersingh24 avatar Dec 13 '22 09:12 mastersingh24

Yep, it worked. Thanks @mastersingh24!

Feggah avatar Dec 13 '22 13:12 Feggah