djinni-generator icon indicating copy to clipboard operation
djinni-generator copied to clipboard

`--c-wrapper-include-cpp-prefix` should default to the value of `--cpp-include-prefix`

Open a4z opened this issue 4 years ago • 1 comments
trafficstars

It seems the python generator does not make use of the --cpp-include-prefix when writeing including files in the generated C wrapper, but only includes the base file name. This breaks builds where public generated cpp files are expected to be found based on a base include directory.

a4z avatar Jul 09 '21 07:07 a4z

luckily, the problem seem to boil down to setting some sensible default values of command line arguments e.g. --c-wrapper-include-cpp-prefix should default to the value of --cpp-include-prefix

and make the documentation more/better visible, to separate the C wrapper options from the python options

a4z avatar Jul 10 '21 17:07 a4z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 18 '23 14:01 stale[bot]