djinni-generator icon indicating copy to clipboard operation
djinni-generator copied to clipboard

[Draft] External symbol support for c wrapper

Open gibutm opened this issue 3 years ago • 3 comments

Raising a draft PR for review and suggestions.

gibutm avatar Oct 24 '22 11:10 gibutm

Thanks a lot @gibutm !

I guess this PR targets #140 ?

Since you commit the first time, the CI does not auto-trigger for your commit. This is a security feature of github. I run it now, and it reports some formatting issues.

Please see code-formatting documentation for more information.

Not sure if CI will auto-trigger after your next commit, or if I have to do it manually again, will see.

a4z avatar Oct 24 '22 13:10 a4z

Thanks for triggering the CI checks, this PR targets #139. I may need some help in understanding how the python layer interacts with the C wrapper before i can give #140 a crack.

I will correct the formatting and update the PR in the meanwhile.

gibutm avatar Oct 24 '22 13:10 gibutm

Hi @gibutm! I'm curious about your use case. Do you use the C wrapper without Python?

Would it be possible to add some tests for the scenario you're covering?

Thank you!

freitass avatar Oct 24 '22 23:10 freitass

Hi @gibutm , please check https://github.com/gibutm/djinni-generator/pull/1 If you merge this, this PR should become green. Or are you not interested in that feature anymore?

a4z avatar Jan 15 '23 19:01 a4z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Mar 17 '23 02:03 github-actions[bot]