fritzbox-cloudflare-dyndns icon indicating copy to clipboard operation
fritzbox-cloudflare-dyndns copied to clipboard

Add possibility to pass secrets via files

Open britter opened this issue 1 year ago • 5 comments

Resolves #30

britter avatar Oct 04 '24 14:10 britter

Tested this in my homelab and it looks like it's working.

britter avatar Oct 04 '24 14:10 britter

@cromefire I addressed the two code comments.

Also the docker samples in the readme should be updated accordingly to make use of secrets.

I don't use docker that much so I don't exactly know how to pass secrets via files. Would you mind adding this yourself on top of my changes?

britter avatar Oct 04 '24 18:10 britter

Yeah was planning to, but I probably won't get to it today, I'll try and add it in the coming days, when I test it locally anyways.

cromefire avatar Oct 04 '24 18:10 cromefire

Hey @cromefire did you have a chance to look into this yet? Would love to have a release with this included.

britter avatar Oct 11 '24 18:10 britter

No I didn't have any time to look at it or test it yet. Time's currently very scarce for me, I hope I do get to it in the next few days, but thanks for the reminder.

cromefire avatar Oct 11 '24 18:10 cromefire

Hey @cromefire I've given it a shot and added an example for how to use the new feature with docker compose secrets. Let me know what you think!

britter avatar Oct 24 '24 09:10 britter

v1.3.0 has been created, binaries are attached and containers are built

cromefire avatar Oct 25 '24 17:10 cromefire