Cromefire_

Results 217 comments of Cromefire_

Still an existing bug, workaround results in invalid key format

Yeah it finds just everything with gitlab in it, like: ``` import com.gitlab.something.something ``` Mean while the do have a [list of actual secrets](https://docs.gitlab.com/ee/user/application_security/secret_detection/pipeline/detected_secrets.html) in use with GitLab. The most...

What would be important I think (and here I don't know your API good enough) is that the gain map should be scaled and flipped similarly to the primary image....

> For libvips it'd be best to transform to a HDR float image on load, maybe with a new operation called `ultrahdr2float` (for example). libvips HDR uses the `scRGB` interpretation...

I think you misunderstand, you cannot "regenerate" the gain map (from what would you regenerate it). You'll need to do transformations like crop twice, once on the SDR image and...

> You can use the gain map as the exponent. It won't match the original SDR + gain map Yeah well that's the issue. In that case just treating it...

> How about: > > * by default, just load the SDR and have a metadata item (eg. `ultrahdr` set to 1) to tag it as an ultrahdr image >...

Maybe to emphasize the point that tonemapping is probably a bad idea (at least without the explicit instruction to do so and/or as the only way possible/the default way of...

> That won't work well with the libvips design -- new_from_file is supposed to always be quick and only read the image header, but the design of ultrahdr means you...

> For conversion to other HDR formats, do you see that actually getting used? The loss of SDR is a huge quality issue in terms of adapting to a range...