cribbl
Post events
Description
Implement the post events feature to collect data after completion of event.
Type of Change:
- [x] New feature (non-breaking change which adds functionality)
@bhawesh96 @rsarky check the new updates and tell me for further changes.
There are some issues.
- postEventContainer.js and postEventContainer1.js
- this.handleNotes does not exist in postEventContainer.js
- Db updates are skewed.
- Where are you using postEventFlag?
- I can submit the details without entering required fields - number of participants (total and external)
There are some issues.
- postEventContainer.js and postEventContainer1.js
- this.handleNotes does not exist in postEventContainer.js
- Db updates are skewed.
- Where are you using postEventFlag?
- I can submit the details without entering required fields - number of participants (total and external)
@dheeraj-coding can you please check these points? I don't see the changes.
@rsarky , do you think we should scrap this and start afresh on this feature? I'm not in sync with this PR at all and I don't think we have support from Dheeraj.
Not sure if any existing work can salvaged from this. We could start afresh if there is someone willing to pick this up! Although I have come to realise some feature additions to the portal tend to get dropped as the contributor loses interest/ has other priorities. Maybe we can set some milestones that can be merged independently for features that are significant sized like this one. That way even if the assignee drops off without completing we have some mergeable work.