etcd-aws icon indicating copy to clipboard operation
etcd-aws copied to clipboard

Compilation failure due to mismatched function signature in ec2cluster

Open cdelorme opened this issue 9 years ago • 5 comments

The call to WatchLifecycleEvents in the etcd-aws source is short a parameter (the queueURL) according to ec2cluster source.

As a result the project does not compile.

cdelorme avatar Nov 16 '16 16:11 cdelorme

I created a pull request: #15

I am not sure if we want to panic on error, or what will happen if we pass in an empty string.

cdelorme avatar Nov 16 '16 16:11 cdelorme

@crewjam bump. Any change to get https://github.com/crewjam/etcd-aws/pull/14 or https://github.com/crewjam/etcd-aws/pull/15 merged?

pieterlange avatar Jan 11 '17 13:01 pieterlange

Yeah sorry for the delay. Travel today, I'll try to take a look today or tomorrow. On Wed, Jan 11, 2017 at 08:43 Pieter Lange [email protected] wrote:

@crewjam https://github.com/crewjam bump. Any change to get #14 https://github.com/crewjam/etcd-aws/pull/14 or #15 https://github.com/crewjam/etcd-aws/pull/15 merged?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/crewjam/etcd-aws/issues/13#issuecomment-271871388, or mute the thread https://github.com/notifications/unsubscribe-auth/AFY8W1PxyeNPgx3XQx48vvImaMseBv9tks5rRNx8gaJpZM4K0EWv .

crewjam avatar Jan 11 '17 13:01 crewjam

A few days doesn't matter at this point. ;-) Thanks for the continued support on this project.

pieterlange avatar Jan 11 '17 13:01 pieterlange

Merged #14. Is it working for you now?

crewjam avatar Jan 16 '17 13:01 crewjam